[Transition Tracing] Rename transitionCallbacks to unstable_transitionCallbacks (#24920)
Renaming transitionCallbacks to unstable_transitionCallbacks as per convention
Luna Ruan committed
Jul 13, 2022 at 15:27 UTC
f629495199791ce2811661ab50c37aac7898f862
3 files changed
+42
-18
packages/react-dom/src/client/ReactDOMRoot.js
+3
-3
@@ -26,9 +26,9 @@ export type RootType = {
26
export type CreateRootOptions = {
27
unstable_strictMode?: boolean,
28
unstable_concurrentUpdatesByDefault?: boolean,
29
+ unstable_transitionCallbacks?: TransitionTracingCallbacks,
30
identifierPrefix?: string,
31
onRecoverableError?: (error: mixed) => void,
31
- transitionCallbacks?: TransitionTracingCallbacks,
32
...
33
};
34
@@ -216,8 +216,8 @@ export function createRoot(
216
if (options.onRecoverableError !== undefined) {
217
onRecoverableError = options.onRecoverableError;
218
}
219
- if (options.transitionCallbacks !== undefined) {
220
- transitionCallbacks = options.transitionCallbacks;
219
+ if (options.unstable_transitionCallbacks !== undefined) {
220
+ transitionCallbacks = options.unstable_transitionCallbacks;
221
}
222
}
223
packages/react-noop-renderer/src/createReactNoop.js
+3
-3
@@ -68,7 +68,7 @@ type TextInstance = {|
68
|};
69
type HostContext = Object;
70
type CreateRootOptions = {
71
- transitionCallbacks?: TransitionTracingCallbacks,
71
+ unstable_transitionCallbacks?: TransitionTracingCallbacks,
72
...
73
};
74
@@ -828,8 +828,8 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
828
false,
829
'',
830
onRecoverableError,
831
- options && options.transitionCallbacks
832
- ? options.transitionCallbacks
831
+ options && options.unstable_transitionCallbacks
832
+ ? options.unstable_transitionCallbacks
833
: null,
834
);
835
return {
packages/react-reconciler/src/__tests__/ReactTransitionTracing-test.js
+36
-12
@@ -212,7 +212,9 @@ describe('ReactInteractionTracing', () => {
212
);
213
}
214
215
- const root = ReactNoop.createRoot({transitionCallbacks});
215
+ const root = ReactNoop.createRoot({
216
+ unstable_transitionCallbacks: transitionCallbacks,
217
+ });
218
await act(async () => {
219
root.render(<App navigate={false} />);
220
ReactNoop.expire(1000);
@@ -276,7 +278,9 @@ describe('ReactInteractionTracing', () => {
278
);
279
}
280
279
- const root = ReactNoop.createRoot({transitionCallbacks});
281
+ const root = ReactNoop.createRoot({
282
+ unstable_transitionCallbacks: transitionCallbacks,
283
+ });
284
await act(async () => {
285
root.render(<App />);
286
ReactNoop.expire(1000);
@@ -333,7 +337,9 @@ describe('ReactInteractionTracing', () => {
337
);
338
}
339
336
- const root = ReactNoop.createRoot({transitionCallbacks});
340
+ const root = ReactNoop.createRoot({
341
+ unstable_transitionCallbacks: transitionCallbacks,
342
+ });
343
await act(async () => {
344
root.render(<App />);
345
ReactNoop.expire(1000);
@@ -404,7 +410,9 @@ describe('ReactInteractionTracing', () => {
410
);
411
}
412
407
- const root = ReactNoop.createRoot({transitionCallbacks});
413
+ const root = ReactNoop.createRoot({
414
+ unstable_transitionCallbacks: transitionCallbacks,
415
+ });
416
await act(async () => {
417
root.render(<App />);
418
ReactNoop.expire(1000);
@@ -497,7 +505,9 @@ describe('ReactInteractionTracing', () => {
505
);
506
}
507
500
- const root = ReactNoop.createRoot({transitionCallbacks});
508
+ const root = ReactNoop.createRoot({
509
+ unstable_transitionCallbacks: transitionCallbacks,
510
+ });
511
await act(async () => {
512
root.render(<App />);
513
ReactNoop.expire(1000);
@@ -602,7 +612,9 @@ describe('ReactInteractionTracing', () => {
612
);
613
}
614
605
- const root = ReactNoop.createRoot({transitionCallbacks});
615
+ const root = ReactNoop.createRoot({
616
+ unstable_transitionCallbacks: transitionCallbacks,
617
+ });
618
await act(async () => {
619
root.render(<App />);
620
ReactNoop.expire(1000);
@@ -717,7 +729,9 @@ describe('ReactInteractionTracing', () => {
729
);
730
}
731
720
- const root = ReactNoop.createRoot({transitionCallbacks});
732
+ const root = ReactNoop.createRoot({
733
+ unstable_transitionCallbacks: transitionCallbacks,
734
+ });
735
await act(async () => {
736
root.render(<App />);
737
ReactNoop.expire(1000);
@@ -846,7 +860,9 @@ describe('ReactInteractionTracing', () => {
860
);
861
}
862
849
- const root = ReactNoop.createRoot({transitionCallbacks});
863
+ const root = ReactNoop.createRoot({
864
+ unstable_transitionCallbacks: transitionCallbacks,
865
+ });
866
await act(async () => {
867
root.render(<App />);
868
ReactNoop.expire(1000);
@@ -1000,7 +1016,9 @@ describe('ReactInteractionTracing', () => {
1016
);
1017
}
1018
1003
- const root = ReactNoop.createRoot({transitionCallbacks});
1019
+ const root = ReactNoop.createRoot({
1020
+ unstable_transitionCallbacks: transitionCallbacks,
1021
+ });
1022
await act(async () => {
1023
root.render(<App />);
1024
ReactNoop.expire(1000);
@@ -1085,7 +1103,9 @@ describe('ReactInteractionTracing', () => {
1103
);
1104
}
1105
1088
- const root = ReactNoop.createRoot({transitionCallbacks});
1106
+ const root = ReactNoop.createRoot({
1107
+ unstable_transitionCallbacks: transitionCallbacks,
1108
+ });
1109
await act(async () => {
1110
root.render(<App />);
1111
ReactNoop.expire(1000);
@@ -1203,7 +1223,9 @@ describe('ReactInteractionTracing', () => {
1223
);
1224
}
1225
1206
- const root = ReactNoop.createRoot({transitionCallbacks});
1226
+ const root = ReactNoop.createRoot({
1227
+ unstable_transitionCallbacks: transitionCallbacks,
1228
+ });
1229
await act(async () => {
1230
root.render(<App />);
1231
ReactNoop.expire(1000);
@@ -1286,7 +1308,9 @@ describe('ReactInteractionTracing', () => {
1308
);
1309
}
1310
1289
- const root = ReactNoop.createRoot({transitionCallbacks});
1311
+ const root = ReactNoop.createRoot({
1312
+ unstable_transitionCallbacks: transitionCallbacks,
1313
+ });
1314
await act(async () => {
1315
startTransition(
1316
() => root.render(<App markerName="one" markerKey="key" />),