@samitouri / QOS-React / commits / a02eeb59f5

Bail out of dedupe logic in cases where there is an incomplete value descriptor (#6648)

Jason Quense committed Apr 29, 2016 at 18:21 UTC a02eeb59f5a09772476940ac3b7ff70c995983bb
1 file changed +9 -4
src/renderers/dom/client/inputValueTracking.js
+9 -4
@@ -65,10 +65,15 @@ var inputValueTracking = {
65
66 var currentValue = '' + node[valueField];
67
68 - // if someone has already defined a value bail and don't track value
69 - // will cause over reporting of changes, but it's better then a hard failure
70 - // (needed for certain tests that spyOn input values)
71 - if (node.hasOwnProperty(valueField)) {
68 + // if someone has already defined a value or Safari, then bail
69 + // and don't track value will cause over reporting of changes,
70 + // but it's better then a hard failure
71 + // (needed for certain tests that spyOn input values and Safari)
72 + if (
73 + node.hasOwnProperty(valueField) ||
74 + typeof descriptor.get !== 'function' ||
75 + typeof descriptor.set !== 'function'
76 + ) {
77 return;
78 }
79