@samitouri / QOS-React / commits / ad94295f13

Removed test support for medikoo/es6-symbol

There seems to be a bug with medikoo/es6-symbol where the global state affects the implementation of the polyfill. I found this by running the individual test file alone then running all the tests using `grunt test`. I found that it passes when ran alone and failed when ran collectively. I did not find this buggy behavior with zloirock/core-js's implementation of a polyfill for Symbol. Thus, removing I will keep the more popular polyfill (core-js) and remove the buggy polyfill (es6-symbol). If you are reading this and can think of a confounding factor that is causing this bug, please let me know and we can try to work together to add support for medikoo/es6-symbol.

Sam Balana committed Apr 7, 2016 at 17:41 UTC ad94295f139a8190286852e14a5c731065f5f0ba

1 file changed -3

src/isomorphic/classic/types/__tests__/ReactPropTypes-test.js

-3

@@ -823,10 +823,7 @@ describe('ReactPropTypes', function() {

823 });

824

825 it('should not warn for a polyfilled Symbol', function() {

826 - var ES6Symbol = require('es6-symbol/polyfill');

826 var CoreSymbol = require('core-js/library/es6/symbol');

828 -

829 - typeCheckPass(PropTypes.symbol, ES6Symbol('es6-symbol'));

827 typeCheckPass(PropTypes.symbol, CoreSymbol('core-js'));

828 });

829 });