Rename `yarn start` to `yarn dev` and `yarn start:prod` to `yarn start` (#26209)
The `start` convention is a CRA convention but nobody else of the modern frameworks / tools use this convention for a file watcher and dev mode. Instead the common convention is `dev`. Instead `start` is for running a production build that's already been built. --------- Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Sebastian Markbåge committed
Feb 21, 2023 at 14:18 UTC
c8d4eeda5f88f75763cabd20416f4883fe160c95
14 files changed
+38
-38
.circleci/config.yml
+1
-1
@@ -366,7 +366,7 @@ jobs:
366
RELEASE_CHANNEL: stable
367
working_directory: fixtures/dom
368
command: |
369
- yarn prestart
369
+ yarn predev
370
yarn test --maxWorkers=2
371
372
test_fuzz:
fixtures/attribute-behavior/README.md
+1
-1
@@ -8,7 +8,7 @@
8
9
## Instructions
10
11
-`yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn start`
11
+`yarn build --type=UMD_DEV react/index,react-dom && cd fixtures/attribute-behavior && yarn install && yarn dev`
12
13
## Interpretation
14
fixtures/attribute-behavior/package.json
+2
-2
@@ -11,9 +11,9 @@
11
"react-virtualized": "^9.9.0"
12
},
13
"scripts": {
14
- "prestart":
14
+ "predev":
15
"cp ../../build/oss-experimental/react/umd/react.development.js public/ && cp ../../build/oss-experimental/react-dom/umd/react-dom.development.js public/ && cp ../../build/oss-experimental/react-dom/umd/react-dom-server-legacy.browser.development.js public/",
16
- "start": "react-scripts start",
16
+ "dev": "react-scripts start",
17
"build": "react-scripts build",
18
"test": "react-scripts test --env=jsdom",
19
"eject": "react-scripts eject"
fixtures/concurrent/time-slicing/package.json
+1
-1
@@ -12,7 +12,7 @@
12
},
13
"scripts": {
14
"copy-source": "cp -r ../../../build/oss-experimental/* ./node_modules/",
15
- "start": "react-scripts start",
15
+ "dev": "react-scripts start",
16
"build": "react-scripts build",
17
"test": "react-scripts test --env=jsdom",
18
"eject": "react-scripts eject"
fixtures/dom/package.json
+2
-2
@@ -19,8 +19,8 @@
19
"semver": "^5.5.0"
20
},
21
"scripts": {
22
- "start": "react-scripts start",
23
- "prestart": "cp ../../build/oss-stable/scheduler/umd/scheduler-unstable_mock.development.js ../../build/oss-stable/scheduler/umd/scheduler-unstable_mock.production.min.js ../../build/oss-stable/react/umd/react.development.js ../../build/oss-stable/react-dom/umd/react-dom.development.js ../../build/oss-stable/react/umd/react.production.min.js ../../build/oss-stable/react-dom/umd/react-dom.production.min.js ../../build/oss-stable/react-dom/umd/react-dom-server.browser.development.js ../../build/oss-stable/react-dom/umd/react-dom-server.browser.production.min.js ../../build/oss-stable/react-dom/umd/react-dom-test-utils.development.js ../../build/oss-stable/react-dom/umd/react-dom-test-utils.production.min.js public/ && cp -a ../../build/oss-stable/. node_modules",
22
+ "dev": "react-scripts start",
23
+ "predev": "cp ../../build/oss-stable/scheduler/umd/scheduler-unstable_mock.development.js ../../build/oss-stable/scheduler/umd/scheduler-unstable_mock.production.min.js ../../build/oss-stable/react/umd/react.development.js ../../build/oss-stable/react-dom/umd/react-dom.development.js ../../build/oss-stable/react/umd/react.production.min.js ../../build/oss-stable/react-dom/umd/react-dom.production.min.js ../../build/oss-stable/react-dom/umd/react-dom-server.browser.development.js ../../build/oss-stable/react-dom/umd/react-dom-server.browser.production.min.js ../../build/oss-stable/react-dom/umd/react-dom-test-utils.development.js ../../build/oss-stable/react-dom/umd/react-dom-test-utils.production.min.js public/ && cp -a ../../build/oss-stable/. node_modules",
24
"build": "react-scripts build && cp build/index.html build/200.html",
25
"test": "react-scripts test --env=jsdom",
26
"eject": "react-scripts eject"
fixtures/expiration/package.json
+2
-2
@@ -8,9 +8,9 @@
8
"react-scripts": "1.0.17"
9
},
10
"scripts": {
11
- "prestart":
11
+ "predev":
12
"cp ../../build/oss-experimental/react/umd/react.development.js public/ && cp ../../build/oss-experimental/react-dom/umd/react-dom.development.js public/",
13
- "start": "react-scripts start",
13
+ "dev": "react-scripts start",
14
"build": "react-scripts build",
15
"test": "react-scripts test --env=jsdom",
16
"eject": "react-scripts eject"
fixtures/fiber-debugger/package.json
+1
-1
@@ -12,7 +12,7 @@
12
"react-motion": "^0.5.0"
13
},
14
"scripts": {
15
- "start": "react-scripts start",
15
+ "dev": "react-scripts start",
16
"build": "react-scripts build"
17
}
18
}
fixtures/fizz/package.json
+6
-6
@@ -28,12 +28,12 @@
28
"prettier": "1.19.1"
29
},
30
"scripts": {
31
- "start": "concurrently \"npm run server:dev\" \"npm run bundler:dev\"",
32
- "start:prod": "concurrently \"npm run server:prod\" \"npm run bundler:prod\"",
33
- "server:dev": "cross-env NODE_ENV=development nodemon -- --inspect server/server.js",
34
- "server:prod": "cross-env NODE_ENV=production nodemon -- server/server.js",
35
- "bundler:dev": "cross-env NODE_ENV=development nodemon -- scripts/build.js",
36
- "bundler:prod": "cross-env NODE_ENV=production nodemon -- scripts/build.js"
31
+ "dev": "concurrently \"npm run dev:server\" \"npm run dev:bundler\"",
32
+ "start": "concurrently \"npm run start:server\" \"npm run start:bundler\"",
33
+ "dev:server": "cross-env NODE_ENV=development nodemon -- --inspect server/server.js",
34
+ "start:server": "cross-env NODE_ENV=production nodemon -- server/server.js",
35
+ "dev:bundler": "cross-env NODE_ENV=development nodemon -- scripts/build.js",
36
+ "start:bundler": "cross-env NODE_ENV=production nodemon -- scripts/build.js"
37
},
38
"babel": {
39
"presets": [
fixtures/flight/package.json
+7
-7
@@ -63,14 +63,14 @@
63
"workbox-webpack-plugin": "^6.4.1"
64
},
65
"scripts": {
66
- "prestart": "cp -r ../../build/oss-experimental/* ./node_modules/",
66
+ "predev": "cp -r ../../build/oss-experimental/* ./node_modules/",
67
"prebuild": "cp -r ../../build/oss-experimental/* ./node_modules/",
68
- "start": "concurrently \"npm run start:server\" \"npm run start:client\"",
69
- "start:client": "NODE_ENV=development BUILD_PATH=dist node scripts/start.js",
70
- "start:server": "NODE_ENV=development BUILD_PATH=dist nodemon -- --experimental-loader ./loader/index.js --conditions=react-server server",
71
- "start:prod": "node scripts/build.js && concurrently \"npm run start:prod-server\" \"npm run start:prod-client\"",
72
- "start:prod-client": "cd ./build && python -m SimpleHTTPServer 3000",
73
- "start:prod-server": "NODE_ENV=production node --experimental-loader ./loader/index.js --conditions=react-server server",
68
+ "dev": "concurrently \"npm run dev:server\" \"npm run dev:client\"",
69
+ "dev:client": "NODE_ENV=development BUILD_PATH=dist node scripts/start.js",
70
+ "dev:server": "NODE_ENV=development BUILD_PATH=dist nodemon -- --experimental-loader ./loader/index.js --conditions=react-server server",
71
+ "start": "node scripts/build.js && concurrently \"npm run start:server\" \"npm run start:client\"",
72
+ "start:client": "cd ./build && python3 -m http.server 3000",
73
+ "start:server": "NODE_ENV=production node --experimental-loader ./loader/index.js --conditions=react-server server",
74
"build": "node scripts/build.js",
75
"test": "node scripts/test.js --env=jsdom"
76
},
fixtures/nesting/package.json
+3
-3
@@ -15,9 +15,9 @@
15
"watch:legacy": "cpx 'src/shared/**' 'src/legacy/shared/' --watch --no-initial",
16
"watch:modern": "cpx 'src/shared/**' 'src/modern/shared/' --watch --no-initial",
17
"prebuild": "run-p copy:*",
18
- "prestart": "run-p copy:*",
19
- "start": "run-p start-app watch:*",
20
- "start-app": "react-scripts start",
18
+ "predev": "run-p copy:*",
19
+ "dev": "run-p dev-app watch:*",
20
+ "dev-app": "react-scripts start",
21
"build": "react-scripts build",
22
"eject": "react-scripts eject"
23
},
fixtures/ssr/package.json
+4
-4
@@ -16,10 +16,10 @@
16
"react-dom": "link:../../build/oss-experimental/react-dom"
17
},
18
"scripts": {
19
- "start": "concurrently \"npm run start:server\" \"npm run start:client\"",
20
- "start:client": "PORT=3001 react-scripts start",
21
- "start:server": "NODE_ENV=development node server",
22
- "start:prod": "react-scripts build && NODE_ENV=production node server",
19
+ "dev": "concurrently \"npm run dev:server\" \"npm run dev:client\"",
20
+ "dev:client": "PORT=3001 react-scripts start",
21
+ "dev:server": "NODE_ENV=development node server",
22
+ "start": "react-scripts build && NODE_ENV=production node server",
23
"build": "react-scripts build",
24
"test": "react-scripts test --env=jsdom",
25
"eject": "react-scripts eject"
fixtures/ssr2/package.json
+6
-6
@@ -28,12 +28,12 @@
28
"prettier": "1.19.1"
29
},
30
"scripts": {
31
- "start": "concurrently \"npm run server:dev\" \"npm run bundler:dev\"",
32
- "start:prod": "concurrently \"npm run server:prod\" \"npm run bundler:prod\"",
33
- "server:dev": "cross-env NODE_ENV=development nodemon -- server/server.js",
34
- "server:prod": "cross-env NODE_ENV=production nodemon -- server/server.js",
35
- "bundler:dev": "cross-env NODE_ENV=development nodemon -- scripts/build.js",
36
- "bundler:prod": "cross-env NODE_ENV=production nodemon -- scripts/build.js"
31
+ "dev": "concurrently \"npm run dev:server\" \"npm run dev:bundler\"",
32
+ "start": "concurrently \"npm run start:server\" \"npm run start:bundler\"",
33
+ "dev:server": "cross-env NODE_ENV=development nodemon -- server/server.js",
34
+ "start:server": "cross-env NODE_ENV=production nodemon -- server/server.js",
35
+ "dev:bundler": "cross-env NODE_ENV=development nodemon -- scripts/build.js",
36
+ "start:bundler": "cross-env NODE_ENV=production nodemon -- scripts/build.js"
37
},
38
"babel": {
39
"presets": [
netlify.toml
+1
-1
@@ -1,7 +1,7 @@
1
[build]
2
base = ""
3
publish = "fixtures/dom/build"
4
- command = "yarn build --type=UMD_DEV && cd fixtures/dom/ && yarn && yarn prestart && yarn build"
4
+ command = "yarn build --type=UMD_DEV && cd fixtures/dom/ && yarn && yarn predev && yarn build"
5
6
[[redirects]]
7
from = "/*"
package.json
+1
-1
@@ -135,7 +135,7 @@
135
"test-build-prod": "yarn test --deprecated 'yarn test --build --prod'",
136
"test-build-devtools": "node ./scripts/jest/jest-cli.js --build --project devtools --release-channel=experimental",
137
"debug-test-build-devtools": "yarn test --deprecated 'yarn test-build-devtools --debug'",
138
- "test-dom-fixture": "cd fixtures/dom && yarn && yarn prestart && yarn test",
138
+ "test-dom-fixture": "cd fixtures/dom && yarn && yarn predev && yarn test",
139
"flow": "node ./scripts/tasks/flow.js",
140
"flow-ci": "node ./scripts/tasks/flow-ci.js",
141
"prettier": "node ./scripts/prettier/index.js write-changed",