cocci: Do not initialize variable used by QTAILQ_FOREACH macro
The QTAILQ_FOREACH() macro, defined in "qemu/queue.h", always assigns its iterator variable when entering the loop. Remove the pointless and possibly misleading assignment. Mechanical patch using the following coccinelle spatch: @@ type T; identifier e; iterator FOREACH_MACRO =~ ".*_FOREACH.*"; statement S; @@ - T *e = ...; + T *e; ... when != e FOREACH_MACRO(e, ...) S Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> Message-Id: <20260415215539.92629-5-philmd@linaro.org>
Philippe Mathieu-Daudé committed
Apr 15, 2026 at 23:11 UTC
29e182003bcbd404167dcff54e05486f98d27388
5 files changed
+7
-7
hw/ppc/spapr.c
+1
-1
@@ -3685,7 +3685,7 @@ struct SpaprDimmState {
3685
static SpaprDimmState *spapr_pending_dimm_unplugs_find(SpaprMachineState *s,
3686
PCDIMMDevice *dimm)
3687
{
3688
- SpaprDimmState *dimm_state = NULL;
3688
+ SpaprDimmState *dimm_state;
3689
3690
QTAILQ_FOREACH(dimm_state, &s->pending_dimm_unplugs, next) {
3691
if (dimm_state->dimm == dimm) {
hw/ppc/spapr_events.c
+2
-2
@@ -460,7 +460,7 @@ static void rtas_event_log_queue(SpaprMachineState *spapr,
460
static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,
461
uint32_t event_mask)
462
{
463
- SpaprEventLogEntry *entry = NULL;
463
+ SpaprEventLogEntry *entry;
464
465
QTAILQ_FOREACH(entry, &spapr->pending_events, next) {
466
const SpaprEventSource *source =
@@ -482,7 +482,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,
482
483
static bool rtas_event_log_contains(SpaprMachineState *spapr, uint32_t event_mask)
484
{
485
- SpaprEventLogEntry *entry = NULL;
485
+ SpaprEventLogEntry *entry;
486
487
QTAILQ_FOREACH(entry, &spapr->pending_events, next) {
488
const SpaprEventSource *source =
net/colo-compare.c
+2
-2
@@ -1396,7 +1396,7 @@ static void colo_compare_init(Object *obj)
1396
1397
void colo_compare_cleanup(void)
1398
{
1399
- CompareState *tmp = NULL;
1399
+ CompareState *tmp;
1400
CompareState *n = NULL;
1401
1402
QTAILQ_FOREACH_SAFE(tmp, &net_compares, next, n) {
@@ -1407,7 +1407,7 @@ void colo_compare_cleanup(void)
1407
static void colo_compare_finalize(Object *obj)
1408
{
1409
CompareState *s = COLO_COMPARE(obj);
1410
- CompareState *tmp = NULL;
1410
+ CompareState *tmp;
1411
1412
qemu_mutex_lock(&colo_compare_mutex);
1413
QTAILQ_FOREACH(tmp, &net_compares, next) {
net/net.c
+1
-1
@@ -653,7 +653,7 @@ static ssize_t filter_receive_iov(NetClientState *nc,
653
NetPacketSent *sent_cb)
654
{
655
ssize_t ret = 0;
656
- NetFilterState *nf = NULL;
656
+ NetFilterState *nf;
657
658
if (direction == NET_FILTER_DIRECTION_TX) {
659
QTAILQ_FOREACH(nf, &nc->filters, next) {
target/s390x/kvm/stsi-topology.c
+1
-1
@@ -285,7 +285,7 @@ static void s390_topology_fill_list_sorted(S390TopologyList *topology_list)
285
*/
286
static void s390_topology_empty_list(S390TopologyList *topology_list)
287
{
288
- S390TopologyEntry *entry = NULL;
288
+ S390TopologyEntry *entry;
289
S390TopologyEntry *tmp = NULL;
290
291
QTAILQ_FOREACH_SAFE(entry, topology_list, next, tmp) {