@samitouri / QOSamiQemu / commits / 3200552839

target/i386: Remove MonitorDef register entries available via gdbstub

All these registers are already provided by via gdbstub parsed XML and handler by the gdb_get_register() helper in the monitor/hmp.c file. Remove as now unreachable code. Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-ID: <20260219191955.83815-19-philmd@linaro.org>

Philippe Mathieu-Daudé committed Feb 15, 2026 at 13:11 UTC 32005528394f967860517b621b3d378a11d3a46c
1 file changed -39
target/i386/monitor.c
-39
@@ -602,46 +602,7 @@ static target_long monitor_get_pc(Monitor *mon, const struct MonitorDef *md,
602
603 const MonitorDef monitor_defs[] = {
604 #define SEG(name, seg) \
605 - { name, offsetof(CPUX86State, segs[seg].selector), NULL, MD_I32 },\
606 - { name ".base", offsetof(CPUX86State, segs[seg].base) },\
605 { name ".limit", offsetof(CPUX86State, segs[seg].limit), NULL, MD_I32 },
608 -
609 - { "eax", offsetof(CPUX86State, regs[0]) },
610 - { "ecx", offsetof(CPUX86State, regs[1]) },
611 - { "edx", offsetof(CPUX86State, regs[2]) },
612 - { "ebx", offsetof(CPUX86State, regs[3]) },
613 - { "esp|sp", offsetof(CPUX86State, regs[4]) },
614 - { "ebp|fp", offsetof(CPUX86State, regs[5]) },
615 - { "esi", offsetof(CPUX86State, regs[6]) },
616 - { "edi", offsetof(CPUX86State, regs[7]) },
617 -#ifdef TARGET_X86_64
618 - { "r8", offsetof(CPUX86State, regs[8]) },
619 - { "r9", offsetof(CPUX86State, regs[9]) },
620 - { "r10", offsetof(CPUX86State, regs[10]) },
621 - { "r11", offsetof(CPUX86State, regs[11]) },
622 - { "r12", offsetof(CPUX86State, regs[12]) },
623 - { "r13", offsetof(CPUX86State, regs[13]) },
624 - { "r14", offsetof(CPUX86State, regs[14]) },
625 - { "r15", offsetof(CPUX86State, regs[15]) },
626 - { "r16", offsetof(CPUX86State, regs[16]) },
627 - { "r17", offsetof(CPUX86State, regs[17]) },
628 - { "r18", offsetof(CPUX86State, regs[18]) },
629 - { "r19", offsetof(CPUX86State, regs[19]) },
630 - { "r20", offsetof(CPUX86State, regs[20]) },
631 - { "r21", offsetof(CPUX86State, regs[21]) },
632 - { "r22", offsetof(CPUX86State, regs[22]) },
633 - { "r23", offsetof(CPUX86State, regs[23]) },
634 - { "r24", offsetof(CPUX86State, regs[24]) },
635 - { "r25", offsetof(CPUX86State, regs[25]) },
636 - { "r26", offsetof(CPUX86State, regs[26]) },
637 - { "r27", offsetof(CPUX86State, regs[27]) },
638 - { "r28", offsetof(CPUX86State, regs[28]) },
639 - { "r29", offsetof(CPUX86State, regs[29]) },
640 - { "r30", offsetof(CPUX86State, regs[30]) },
641 - { "r31", offsetof(CPUX86State, regs[31]) },
642 -#endif
643 - { "eflags", offsetof(CPUX86State, eflags) },
644 - { "eip", offsetof(CPUX86State, eip) },
606 SEG("cs", R_CS)
607 SEG("ds", R_DS)
608 SEG("es", R_ES)