@samitouri / QOSamiQemu / commits / 4e8ac6857f

hw/remote/machine.c: Mark x-remote machine as OK for AArch64 and AArch32

When we updated Arm and AArch64 board types to mark them for the target_machine_typename() filter, we forgot about the "x-remote" machine type, which meant that it disappeared from the set of board types exposed on the qemu-system-arm and qemu-system-aarch64 binaries. We didn't notice this, because although we have a functional test for it, it requires the KVM accelerator and we don't run the functional tests on an AArch64 host in CI. Mark the machine as being OK to expose in qemu-system-arm and qemu-system-aarch64, in the same way we do for the "none" machine type. This fixes a check-functional failure on aarch64 host, where it would otherwise fail with: qemu-system-aarch64: unsupported machine type: "x-remote" Cc: qemu-stable@nongnu.org Fixes: eb796c55513d9d39 ("hw/core: Allow ARM/Aarch64 binaries to use the 'none' machine") Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-id: 20260507194728.2034696-2-peter.maydell@linaro.org

Peter Maydell committed May 7, 2026 at 20:47 UTC 4e8ac6857faab29f8d6e149f4d71aeb057884496
1 file changed +3
hw/remote/machine.c
+3
@@ -24,6 +24,7 @@
24 #include "hw/core/qdev.h"
25 #include "hw/remote/vfio-user-obj.h"
26 #include "hw/pci/msi.h"
27 +#include "hw/arm/machines-qom.h"
28
29 static void remote_machine_init(MachineState *machine)
30 {
@@ -148,6 +149,8 @@ static const TypeInfo remote_machine = {
149 .class_init = remote_machine_class_init,
150 .interfaces = (const InterfaceInfo[]) {
151 { TYPE_HOTPLUG_HANDLER },
152 + { TYPE_TARGET_AARCH64_MACHINE },
153 + { TYPE_TARGET_ARM_MACHINE },
154 { }
155 }
156 };