@samitouri / QOSamiQemu / commits / 53d7019663

scripts/modinfo: use f-strings

Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com> Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Marc-André Lureau committed Jan 20, 2026 at 11:33 UTC 53d70196633ac214f332822eb95df2b8e4c48fe2
1 file changed +6 -8
scripts/modinfo-generate.py
+6 -8
@@ -9,7 +9,7 @@ def print_array(name: str, values: list[str]) -> None:
9 if len(values) == 0:
10 return
11 list = ", ".join(values)
12 - print(" .%s = ((const char*[]){ %s, NULL })," % (name, list))
12 + print(f" .{name} = ((const char*[]){{ {list}, NULL }}),")
13
14 def parse_line(line: str) -> tuple[str, str]:
15 kind = ""
@@ -53,17 +53,16 @@ def generate(name: str, lines: list[str], enabled: set[str]) -> Optional[set[str
53 # don't add a module which dependency is not enabled
54 # in kconfig
55 if data.strip() not in enabled:
56 - print(" /* module {} isn't enabled in Kconfig. */"
57 - .format(data.strip()))
56 + print(f" /* module {data.strip()} isn't enabled in Kconfig. */")
57 print("/* },{ */")
58 return None
59 else:
60 print("unknown:", kind)
61 exit(1)
62
64 - print(" .name = \"%s\"," % name)
63 + print(f' .name = "{name}",')
64 if arch != "":
66 - print(" .arch = %s," % arch)
65 + print(f" .arch = {arch},")
66 print_array("objs", objs)
67 print_array("deps", deps)
68 print_array("opts", opts)
@@ -100,7 +99,7 @@ def main(args: list[str]) -> None:
99 for modinfo in args[2:]:
100 with open(modinfo) as f:
101 lines = f.readlines()
103 - print(" /* %s */" % modinfo)
102 + print(f" /* {modinfo} */")
103 (basename, _) = os.path.splitext(modinfo)
104 moddeps = generate(basename, lines, enabled)
105 if moddeps is not None:
@@ -110,8 +109,7 @@ def main(args: list[str]) -> None:
109
110 error = False
111 for dep in deps.difference(modules):
113 - print("Dependency {} cannot be satisfied".format(dep),
114 - file=sys.stderr)
112 + print(f"Dependency {dep} cannot be satisfied", file=sys.stderr)
113 error = True
114
115 if error: