audio: Clamp unsigned sample conversion
clip_*_uint32_t() returns 0 when v == 1.f because it computes the result as (IN_T)((v * ((mixeng_real)IN_MAX / 2.f)) + HALF): - (v * ((mixeng_real)IN_MAX / 2.f)) + HALF == 0x100000000.f, which does not fit in uint32_t. - (v * ((mixeng_real)IN_MAX / 2.f)) == 0x80000000.f - ((mixeng_real)IN_MAX / 2.f) == 0x80000000.f - (mixeng_real)IN_MAX == 0x100000000.f because 0xffffffff cannot be represented exactly in float. - HALF == 0x7fffffff, which is implicitly converted to 0x80000000.f. Clamp the result to avoid the overflow. Signed-off-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp> Acked-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-Id: <20260423-audio-v1-2-e1d6b65c76f9@rsg.ci.i.u-tokyo.ac.jp>
Akihiko Odaki committed
Apr 23, 2026 at 22:55 UTC
698399705c016b6f3bf64e466a43882d5873bb50
1 file changed
+3
-1
audio/mixeng_template.h
+3
-1
@@ -65,7 +65,9 @@ static inline IN_T glue (clip_, ET) (mixeng_real v)
65
#ifdef SIGNED
66
return ENDIAN_CONVERT((IN_T)(v * (((mixeng_real)IN_MAX - IN_MIN) / 2.f)));
67
#else
68
- return ENDIAN_CONVERT((IN_T)((v * ((mixeng_real)IN_MAX / 2.f)) + HALF));
68
+ return ENDIAN_CONVERT(MIN((int64_t)((v * ((mixeng_real)IN_MAX / 2.f)) +
69
+ HALF),
70
+ IN_MAX));
71
#endif
72
}
73