@samitouri / QOSamiQemu / commits / 6bf9910a8e

monitor: Restrict monitor_set_cpu() method scope

As mentioned in commit 755f196898e ("qapi: Convert the cpu command") 15 years ago, the monitor_set_cpu() method is a temporary bridge between QMP -> HMP and shouldn't be used elsewhere. Make its scope internal to monitor/. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20260427080738.77138-8-philmd@linaro.org>

Philippe Mathieu-Daudé committed Apr 13, 2026 at 13:00 UTC 6bf9910a8e68d1bd1d9408e501a5d3268705c4bf
2 files changed +1 -1
include/monitor/monitor.h
-1
@@ -37,7 +37,6 @@ int monitor_vprintf(Monitor *mon, const char *fmt, va_list ap)
37 int monitor_printf(Monitor *mon, const char *fmt, ...) G_GNUC_PRINTF(2, 3);
38 void monitor_printc(Monitor *mon, int ch);
39 void monitor_flush(Monitor *mon);
40 -int monitor_set_cpu(Monitor *mon, int cpu_index);
40 int monitor_get_cpu_index(Monitor *mon);
41
42 int monitor_puts_locked(Monitor *mon, const char *str);
monitor/monitor-internal.h
+1
@@ -175,6 +175,7 @@ void monitor_data_destroy(Monitor *mon);
175 int monitor_can_read(void *opaque);
176 void monitor_list_append(Monitor *mon);
177 void monitor_fdsets_cleanup(void);
178 +int monitor_set_cpu(Monitor *mon, int cpu_index);
179
180 void qmp_send_response(MonitorQMP *mon, const QDict *rsp);
181 void monitor_data_destroy_qmp(MonitorQMP *mon);