@samitouri / QOSamiQemu / commits / 78532838ab

migration/qemu-file: drop incorrect const from qemu_get_buffer_at buf

qemu_get_buffer_at() reads data *into* buf -- it should not be const. Drop the qualifier and remove the now-unnecessary cast. Signed-off-by: Junjie Cao <junjie.cao@intel.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Peter Xu <peterx@redhat.com> Link: https://lore.kernel.org/qemu-devel/20260420201317.30199-4-junjie.cao@intel.com Signed-off-by: Fabiano Rosas <farosas@suse.de>

Junjie Cao committed Apr 21, 2026 at 04:13 UTC 78532838ab9edeaced231760693898614280cbb5
2 files changed +3 -3
migration/qemu-file.c
+2 -2
@@ -550,7 +550,7 @@ void qemu_put_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,
550 }
551
552
553 -size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,
553 +size_t qemu_get_buffer_at(QEMUFile *f, uint8_t *buf, size_t buflen,
554 off_t pos)
555 {
556 Error *err = NULL;
@@ -559,7 +559,7 @@ size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,
559 return 0;
560 }
561
562 - if (qio_channel_pread_all(f->ioc, (char *)buf, buflen, pos, &err) < 0) {
562 + if (qio_channel_pread_all(f->ioc, buf, buflen, pos, &err) < 0) {
563 qemu_file_set_error_obj(f, -EIO, err);
564 return 0;
565 }
migration/qemu-file.h
+1 -1
@@ -76,7 +76,7 @@ void qemu_set_offset(QEMUFile *f, off_t off, int whence);
76 off_t qemu_get_offset(QEMUFile *f);
77 void qemu_put_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,
78 off_t pos);
79 -size_t qemu_get_buffer_at(QEMUFile *f, const uint8_t *buf, size_t buflen,
79 +size_t qemu_get_buffer_at(QEMUFile *f, uint8_t *buf, size_t buflen,
80 off_t pos);
81
82 QIOChannel *qemu_file_get_ioc(QEMUFile *file);