@samitouri / QOSamiQemu / commits / 78dc8c8253

target/riscv: Explode MO_TExx -> MO_TE | MO_xx (again)

Following commit 73ae67fd4e6, extract the implicit MO_TE definition in order to replace it. Mechanical change using: $ for n in UW UL UQ UO SW SL SQ; do \ sed -i -e "s/MO_TE$n/MO_TE | MO_$n/" \ $(git grep -l MO_TE$n target/riscv); \ done Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Message-ID: <20260318103122.97244-6-philmd@linaro.org> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>

Philippe Mathieu-Daudé committed Mar 18, 2026 at 11:31 UTC 78dc8c8253e4e54d5f49ef19243431ccc61d68c4
3 files changed +16 -16
target/riscv/insn_trans/trans_rvzalasr.c.inc
+6 -6
@@ -49,20 +49,20 @@ static bool trans_lb_aqrl(DisasContext *ctx, arg_lb_aqrl *a)
49 static bool trans_lh_aqrl(DisasContext *ctx, arg_lh_aqrl *a)
50 {
51 REQUIRE_ZALASR(ctx);
52 - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TESW));
52 + return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_SW));
53 }
54
55 static bool trans_lw_aqrl(DisasContext *ctx, arg_lw_aqrl *a)
56 {
57 REQUIRE_ZALASR(ctx);
58 - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TESL));
58 + return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_SL));
59 }
60
61 static bool trans_ld_aqrl(DisasContext *ctx, arg_ld_aqrl *a)
62 {
63 REQUIRE_64BIT(ctx);
64 REQUIRE_ZALASR(ctx);
65 - return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TEUQ));
65 + return gen_load_acquire(ctx, a, (MO_ALIGN | MO_TE | MO_UQ));
66 }
67
68 static bool gen_store_release(DisasContext *ctx, arg_sb_aqrl *a, MemOp memop)
@@ -96,18 +96,18 @@ static bool trans_sb_aqrl(DisasContext *ctx, arg_sb_aqrl *a)
96 static bool trans_sh_aqrl(DisasContext *ctx, arg_sh_aqrl *a)
97 {
98 REQUIRE_ZALASR(ctx);
99 - return gen_store_release(ctx, a, (MO_ALIGN | MO_TESW));
99 + return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_SW));
100 }
101
102 static bool trans_sw_aqrl(DisasContext *ctx, arg_sw_aqrl *a)
103 {
104 REQUIRE_ZALASR(ctx);
105 - return gen_store_release(ctx, a, (MO_ALIGN | MO_TESL));
105 + return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_SL));
106 }
107
108 static bool trans_sd_aqrl(DisasContext *ctx, arg_sd_aqrl *a)
109 {
110 REQUIRE_64BIT(ctx);
111 REQUIRE_ZALASR(ctx);
112 - return gen_store_release(ctx, a, (MO_ALIGN | MO_TEUQ));
112 + return gen_store_release(ctx, a, (MO_ALIGN | MO_TE | MO_UQ));
113 }
target/riscv/insn_trans/trans_xmips.c.inc
+8 -8
@@ -56,11 +56,11 @@ static bool trans_ldp(DisasContext *ctx, arg_ldp *a)
56 TCGv addr = tcg_temp_new();
57
58 tcg_gen_addi_tl(addr, src, a->imm_y);
59 - tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TESQ);
59 + tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TE | MO_SQ);
60 gen_set_gpr(ctx, a->rd, dest0);
61
62 tcg_gen_addi_tl(addr, addr, 8);
63 - tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TESQ);
63 + tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TE | MO_SQ);
64 gen_set_gpr(ctx, a->rs3, dest1);
65
66 return true;
@@ -77,11 +77,11 @@ static bool trans_lwp(DisasContext *ctx, arg_lwp *a)
77 TCGv addr = tcg_temp_new();
78
79 tcg_gen_addi_tl(addr, src, a->imm_x);
80 - tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TESL);
80 + tcg_gen_qemu_ld_tl(dest0, addr, ctx->mem_idx, MO_TE | MO_SL);
81 gen_set_gpr(ctx, a->rd, dest0);
82
83 tcg_gen_addi_tl(addr, addr, 4);
84 - tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TESL);
84 + tcg_gen_qemu_ld_tl(dest1, addr, ctx->mem_idx, MO_TE | MO_SL);
85 gen_set_gpr(ctx, a->rs3, dest1);
86
87 return true;
@@ -99,10 +99,10 @@ static bool trans_sdp(DisasContext *ctx, arg_sdp *a)
99 TCGv addr = tcg_temp_new();
100
101 tcg_gen_addi_tl(addr, src, a->imm_w);
102 - tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TEUQ);
102 + tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TE | MO_UQ);
103
104 tcg_gen_addi_tl(addr, addr, 8);
105 - tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TEUQ);
105 + tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TE | MO_UQ);
106
107 return true;
108 }
@@ -118,10 +118,10 @@ static bool trans_swp(DisasContext *ctx, arg_swp *a)
118 TCGv addr = tcg_temp_new();
119
120 tcg_gen_addi_tl(addr, src, a->imm_v);
121 - tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TESL);
121 + tcg_gen_qemu_st_tl(data0, addr, ctx->mem_idx, MO_TE | MO_SL);
122
123 tcg_gen_addi_tl(addr, addr, 4);
124 - tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TESL);
124 + tcg_gen_qemu_st_tl(data1, addr, ctx->mem_idx, MO_TE | MO_SL);
125
126 return true;
127 }
target/riscv/insn_trans/trans_zilsd.c.inc
+2 -2
@@ -30,7 +30,7 @@ static bool gen_load_i64(DisasContext *ctx, arg_ld *a)
30 TCGv addr = get_address(ctx, a->rs1, a->imm);
31 TCGv_i64 tmp = tcg_temp_new_i64();
32
33 - tcg_gen_qemu_ld_i64(tmp, addr, ctx->mem_idx, MO_TESQ);
33 + tcg_gen_qemu_ld_i64(tmp, addr, ctx->mem_idx, MO_TE | MO_SQ);
34
35 if (a->rd == 0) {
36 return true;
@@ -85,7 +85,7 @@ static bool gen_store_i64(DisasContext *ctx, arg_sd *a)
85 } else {
86 tcg_gen_concat_tl_i64(tmp, data_low, data_high);
87 }
88 - tcg_gen_qemu_st_i64(tmp, addr, ctx->mem_idx, MO_TESQ);
88 + tcg_gen_qemu_st_i64(tmp, addr, ctx->mem_idx, MO_TE | MO_SQ);
89
90 return true;
91 }