@samitouri / QOSamiQemu / commits / be1ea14295

hw/arm/aspeed: free fmc_model and spi_model on finalization

The fmc_model and spi_model strings are allocated via g_strdup in property setters but never freed when the machine object is destroyed. Fixes: 9820e52fbef7 ("hw/arm/aspeed: Add machine properties to define the flash models") Reviewed-by: Cédric Le Goater <clg@redhat.com> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Marc-André Lureau committed Apr 27, 2026 at 16:05 UTC be1ea14295c058e0ac8aeb0097ebde23f80397bd
1 file changed +9
hw/arm/aspeed.c
+9
@@ -419,12 +419,21 @@ static void aspeed_machine_class_init(ObjectClass *oc, const void *data)
419 aspeed_machine_class_props_init(oc);
420 }
421
422 +static void aspeed_machine_instance_finalize(Object *obj)
423 +{
424 + AspeedMachineState *bmc = ASPEED_MACHINE(obj);
425 +
426 + g_free(bmc->fmc_model);
427 + g_free(bmc->spi_model);
428 +}
429 +
430 static const TypeInfo aspeed_machine_types[] = {
431 {
432 .name = TYPE_ASPEED_MACHINE,
433 .parent = TYPE_MACHINE,
434 .instance_size = sizeof(AspeedMachineState),
435 .instance_init = aspeed_machine_instance_init,
436 + .instance_finalize = aspeed_machine_instance_finalize,
437 .class_size = sizeof(AspeedMachineClass),
438 .class_init = aspeed_machine_class_init,
439 .abstract = true,