@samitouri / QOSamiQemu / commits / e4eff9dfaa

target/alpha: Document gdbstub register indexes

Follow GDB XML comments. Re-order switch cases for clarity. Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-ID: <20260219191955.83815-6-philmd@linaro.org>

Philippe Mathieu-Daudé committed Feb 17, 2026 at 08:29 UTC e4eff9dfaad4ccf9d0241825e11747263d026224
1 file changed +12 -13
target/alpha/gdbstub.c
+12 -13
@@ -31,6 +31,9 @@ int alpha_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)
31 case 0 ... 30:
32 val = cpu_alpha_load_gr(env, n);
33 break;
34 + case 31: /* zero register */
35 + val = 0;
36 + break;
37 case 32 ... 62:
38 d.d = env->fir[n - 32];
39 val = d.ll;
@@ -41,15 +44,12 @@ int alpha_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n)
44 case 64:
45 val = env->pc;
46 break;
44 - case 66:
45 - val = env->unique;
46 - break;
47 - case 31:
48 - case 65:
49 - /* 31 really is the zero register; 65 is unassigned in the
50 - gdb protocol, but is still required to occupy 8 bytes. */
47 + case 65: /* former Virtual Register (reserved as unassigned) */
48 val = 0;
49 break;
50 + case 66: /* PALcode Memory Slot */
51 + val = env->unique;
52 + break;
53 default:
54 return 0;
55 }
@@ -66,6 +66,8 @@ int alpha_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
66 case 0 ... 30:
67 cpu_alpha_store_gr(env, n, tmp);
68 break;
69 + case 31: /* zero register */
70 + break;
71 case 32 ... 62:
72 d.ll = tmp;
73 env->fir[n - 32] = d.d;
@@ -76,13 +78,10 @@ int alpha_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n)
78 case 64:
79 env->pc = tmp;
80 break;
79 - case 66:
80 - env->unique = tmp;
81 + case 65: /* former Virtual Register (reserved as unassigned) */
82 break;
82 - case 31:
83 - case 65:
84 - /* 31 really is the zero register; 65 is unassigned in the
85 - gdb protocol, but is still required to occupy 8 bytes. */
83 + case 66: /* PALcode Memory Slot */
84 + env->unique = tmp;
85 break;
86 default:
87 return 0;