@samitouri / QOSamiQemu / commits / f6a029a2a3

minikconf: fix type mismatch in do_declaration

The set stores strings, not Vars. Because of this the duplicate definition check did not work. Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo Bonzini committed Apr 24, 2026 at 10:17 UTC f6a029a2a3b3e2145e3258d49cc371cd9bad712c
1 file changed +2 -2
scripts/minikconf.py
+2 -2
@@ -262,8 +262,8 @@ class KconfigData:
262 # semantic actions -------------
263
264 def do_declaration(self, var):
265 - if (var in self.defined_vars):
266 - raise KconfigDataError('variable "' + var + '" defined twice')
265 + if var.name in self.defined_vars:
266 + raise KconfigDataError('variable "%s" defined twice' % var.name)
267
268 self.defined_vars.add(var.name)
269