| 1 | # SPDX-License-Identifier: Apache-2.0 |
| 2 | # SPDX-FileCopyrightText: Copyright contributors to the vLLM project |
| 3 | """Tests for Idefics3's multimodal preprocessing kwargs.""" |
| 4 | |
| 5 | import pytest |
| 6 | from transformers import Idefics3Config |
| 7 | |
| 8 | from vllm.multimodal import MULTIMODAL_REGISTRY |
| 9 | |
| 10 | from ....conftest import ImageTestAssets |
| 11 | from ...utils import build_model_context |
| 12 | |
| 13 | |
| 14 | @pytest.mark.parametrize("model_id", ["HuggingFaceM4/Idefics3-8B-Llama3"]) |
| 15 | @pytest.mark.parametrize( |
| 16 | ("mm_processor_kwargs", "expected_toks_per_img"), |
| 17 | [ |
| 18 | ({"size": {"longest_edge": 364}}, 169), |
| 19 | ({"size": {"longest_edge": 728}}, 169 * (2**2 + 1)), |
| 20 | ], |
| 21 | ) |
| 22 | @pytest.mark.parametrize("num_imgs", [1, 2]) |
| 23 | @pytest.mark.parametrize("kwargs_on_init", [True, False]) |
| 24 | def test_processor_override( |
| 25 | image_assets: ImageTestAssets, |
| 26 | model_id: str, |
| 27 | mm_processor_kwargs: dict[str, object], |
| 28 | expected_toks_per_img: int, |
| 29 | num_imgs: int, |
| 30 | kwargs_on_init: bool, |
| 31 | ): |
| 32 | """Ensure Idefics3MultiModalProcessor handles num_crops properly.""" |
| 33 | # Same as the previous test - don't initialize mm_processor_kwargs |
| 34 | # in this test and assume that the kwargs will be correctly expanded by |
| 35 | # the partial when calling the custom input processor. |
| 36 | ctx = build_model_context( |
| 37 | model_id, |
| 38 | mm_processor_kwargs=mm_processor_kwargs if kwargs_on_init else None, |
| 39 | limit_mm_per_prompt={"image": num_imgs}, |
| 40 | ) |
| 41 | processor = MULTIMODAL_REGISTRY.create_processor(ctx.model_config) |
| 42 | hf_processor_mm_kwargs = {} if kwargs_on_init else mm_processor_kwargs |
| 43 | |
| 44 | # Build the image str / prompt based on the number of images we pass |
| 45 | placeholders = ( |
| 46 | "<image>" |
| 47 | if num_imgs == 1 |
| 48 | else "\n".join(f"Image-{i}: <image>\n" for i in range(1, num_imgs + 1)) |
| 49 | ) |
| 50 | prompt = f"<|begin_of_text|>User:{placeholders}\n<end_of_utterance>\nAssistant:" # noqa: E501 |
| 51 | |
| 52 | # Build mm_data |
| 53 | image_size = ctx.get_hf_config(Idefics3Config).vision_config.image_size |
| 54 | dummy_image_size = (image_size * 4, image_size * 4) |
| 55 | dummy_image = image_assets[0].pil_image.resize(dummy_image_size) |
| 56 | mm_data = {"image": [dummy_image] * num_imgs} |
| 57 | |
| 58 | processed_inputs = processor( |
| 59 | prompt, |
| 60 | mm_items=processor.info.parse_mm_data(mm_data), |
| 61 | hf_processor_mm_kwargs=hf_processor_mm_kwargs, |
| 62 | ) |
| 63 | |
| 64 | # Ensure the placeholders format are correct |
| 65 | hf_processor = processor.info.get_hf_processor(**hf_processor_mm_kwargs) |
| 66 | hf_processed_inputs = hf_processor( |
| 67 | text=prompt, |
| 68 | images=mm_data["image"], |
| 69 | **processor.info.ctx.get_merged_mm_kwargs(hf_processor_mm_kwargs), |
| 70 | ) |
| 71 | assert processed_inputs["prompt_token_ids"] == hf_processed_inputs["input_ids"][0] |
| 72 | |
| 73 | # Ensure we have the right number of placeholders per num_crops size |
| 74 | image_token_id = ctx.get_hf_config().image_token_id |
| 75 | img_tok_count = processed_inputs["prompt_token_ids"].count(image_token_id) |
| 76 | assert img_tok_count == expected_toks_per_img * num_imgs |