| 1 | #!/bin/sh |
| 2 | # |
| 3 | # |
| 4 | |
| 5 | test_description='git mktag: tag object verify test' |
| 6 | |
| 7 | . ./test-lib.sh |
| 8 | |
| 9 | ########################################################### |
| 10 | # check the tag.sig file, expecting verify_tag() to fail, |
| 11 | # and checking that the error message matches the pattern |
| 12 | # given in the expect.pat file. |
| 13 | |
| 14 | check_verify_failure () { |
| 15 | subject=$1 && |
| 16 | message=$2 && |
| 17 | shift 2 && |
| 18 | |
| 19 | no_strict= && |
| 20 | fsck_obj_ok= && |
| 21 | no_strict= && |
| 22 | while test $# != 0 |
| 23 | do |
| 24 | case "$1" in |
| 25 | --no-strict) |
| 26 | no_strict=yes |
| 27 | ;; |
| 28 | --fsck-obj-ok) |
| 29 | fsck_obj_ok=yes |
| 30 | ;; |
| 31 | esac && |
| 32 | shift |
| 33 | done && |
| 34 | |
| 35 | test_expect_success "fail with [--[no-]strict]: $subject" ' |
| 36 | test_must_fail git mktag <tag.sig 2>err && |
| 37 | if test -z "$no_strict" |
| 38 | then |
| 39 | test_must_fail git mktag <tag.sig 2>err2 && |
| 40 | test_cmp err err2 |
| 41 | else |
| 42 | git mktag --no-strict <tag.sig |
| 43 | fi |
| 44 | ' |
| 45 | |
| 46 | test_expect_success "setup: $subject" ' |
| 47 | tag_ref=refs/tags/bad_tag && |
| 48 | |
| 49 | # Reset any leftover state from the last $subject |
| 50 | rm -rf bad-tag && |
| 51 | |
| 52 | git init --bare bad-tag && |
| 53 | bad_tag=$(git -C bad-tag hash-object -t tag -w --stdin --literally <tag.sig) |
| 54 | ' |
| 55 | |
| 56 | test_expect_success "hash-object & fsck unreachable: $subject" ' |
| 57 | if test -n "$fsck_obj_ok" |
| 58 | then |
| 59 | git -C bad-tag fsck |
| 60 | else |
| 61 | test_must_fail git -C bad-tag fsck |
| 62 | fi |
| 63 | ' |
| 64 | |
| 65 | test_expect_success "update-ref & fsck reachable: $subject" ' |
| 66 | # Make sure the earlier test created it for us |
| 67 | git rev-parse "$bad_tag" && |
| 68 | |
| 69 | # The update-ref of the bad content will fail, do it |
| 70 | # anyway to see if it segfaults |
| 71 | test_might_fail git -C bad-tag update-ref "$tag_ref" "$bad_tag" && |
| 72 | |
| 73 | # Manually create the broken, we cannot do it with |
| 74 | # update-ref |
| 75 | test-tool -C bad-tag ref-store main delete-refs 0 msg "$tag_ref" && |
| 76 | test-tool -C bad-tag ref-store main update-ref msg "$tag_ref" $bad_tag $ZERO_OID REF_SKIP_OID_VERIFICATION && |
| 77 | |
| 78 | # Unlike fsck-ing unreachable content above, this |
| 79 | # will always fail. |
| 80 | test_must_fail git -C bad-tag fsck |
| 81 | ' |
| 82 | |
| 83 | test_expect_success "for-each-ref: $subject" ' |
| 84 | # Make sure the earlier test created it for us |
| 85 | git rev-parse "$bad_tag" && |
| 86 | |
| 87 | test-tool -C bad-tag ref-store main delete-refs 0 msg "$tag_ref" && |
| 88 | test-tool -C bad-tag ref-store main update-ref msg "$tag_ref" $bad_tag $ZERO_OID REF_SKIP_OID_VERIFICATION && |
| 89 | |
| 90 | printf "%s tag\t%s\n" "$bad_tag" "$tag_ref" >expected && |
| 91 | git -C bad-tag for-each-ref "$tag_ref" >actual && |
| 92 | test_cmp expected actual && |
| 93 | |
| 94 | test_must_fail git -C bad-tag for-each-ref --format="%(*objectname)" |
| 95 | ' |
| 96 | |
| 97 | test_expect_success "fast-export & fast-import: $subject" ' |
| 98 | # Make sure the earlier test created it for us |
| 99 | git rev-parse "$bad_tag" && |
| 100 | |
| 101 | test_must_fail git -C bad-tag fast-export --all && |
| 102 | test_must_fail git -C bad-tag fast-export "$bad_tag" |
| 103 | ' |
| 104 | } |
| 105 | |
| 106 | test_expect_mktag_success() { |
| 107 | test_expect_success "$1" ' |
| 108 | git hash-object -t tag -w --stdin <tag.sig >expected && |
| 109 | git fsck --strict && |
| 110 | |
| 111 | git mktag <tag.sig >hash && |
| 112 | test_cmp expected hash && |
| 113 | test_when_finished "git update-ref -d refs/tags/mytag $(cat hash)" && |
| 114 | git update-ref refs/tags/mytag $(cat hash) $(test_oid zero) && |
| 115 | git fsck --strict |
| 116 | ' |
| 117 | } |
| 118 | |
| 119 | ########################################################### |
| 120 | # first create a commit, so we have a valid object/type |
| 121 | # for the tag. |
| 122 | test_expect_success 'setup' ' |
| 123 | test_commit A && |
| 124 | test_commit B && |
| 125 | head=$(git rev-parse --verify HEAD) && |
| 126 | head_parent=$(git rev-parse --verify HEAD~) && |
| 127 | tree=$(git rev-parse HEAD^{tree}) && |
| 128 | blob=$(git rev-parse --verify HEAD:B.t) |
| 129 | ' |
| 130 | |
| 131 | test_expect_success 'basic usage' ' |
| 132 | cat >tag.sig <<-EOF && |
| 133 | object $head |
| 134 | type commit |
| 135 | tag mytag |
| 136 | tagger T A Gger <tagger@example.com> 1206478233 -0500 |
| 137 | EOF |
| 138 | git mktag <tag.sig && |
| 139 | git mktag --end-of-options <tag.sig && |
| 140 | test_expect_code 129 git mktag --unknown-option |
| 141 | ' |
| 142 | |
| 143 | ############################################################ |
| 144 | # 1. length check |
| 145 | |
| 146 | cat >tag.sig <<EOF |
| 147 | too short for a tag |
| 148 | EOF |
| 149 | |
| 150 | check_verify_failure 'Tag object length check' \ |
| 151 | '^error:.* missingObject:' 'strict' |
| 152 | |
| 153 | ############################################################ |
| 154 | # 2. object line label check |
| 155 | |
| 156 | cat >tag.sig <<EOF |
| 157 | xxxxxx $head |
| 158 | type tag |
| 159 | tag mytag |
| 160 | tagger . <> 0 +0000 |
| 161 | |
| 162 | EOF |
| 163 | |
| 164 | check_verify_failure '"object" line label check' '^error:.* missingObject:' |
| 165 | |
| 166 | ############################################################ |
| 167 | # 3. object line hash check |
| 168 | |
| 169 | cat >tag.sig <<EOF |
| 170 | object $(echo $head | tr 0-9a-f z) |
| 171 | type tag |
| 172 | tag mytag |
| 173 | tagger . <> 0 +0000 |
| 174 | |
| 175 | EOF |
| 176 | |
| 177 | check_verify_failure '"object" line check' '^error:.* badObjectSha1:' |
| 178 | |
| 179 | ############################################################ |
| 180 | # 4. type line label check |
| 181 | |
| 182 | cat >tag.sig <<EOF |
| 183 | object $head |
| 184 | xxxx tag |
| 185 | tag mytag |
| 186 | tagger . <> 0 +0000 |
| 187 | |
| 188 | EOF |
| 189 | |
| 190 | check_verify_failure '"type" line label check' '^error:.* missingTypeEntry:' |
| 191 | |
| 192 | ############################################################ |
| 193 | # 5. type line eol check |
| 194 | |
| 195 | echo "object $head" >tag.sig |
| 196 | printf "type tagsssssssssssssssssssssssssssssss" >>tag.sig |
| 197 | |
| 198 | check_verify_failure '"type" line eol check' '^error:.* unterminatedHeader:' |
| 199 | |
| 200 | ############################################################ |
| 201 | # 6. tag line label check #1 |
| 202 | |
| 203 | cat >tag.sig <<EOF |
| 204 | object $head |
| 205 | type tag |
| 206 | xxx mytag |
| 207 | tagger . <> 0 +0000 |
| 208 | |
| 209 | EOF |
| 210 | |
| 211 | check_verify_failure '"tag" line label check #1' \ |
| 212 | '^error:.* missingTagEntry:' |
| 213 | |
| 214 | ############################################################ |
| 215 | # 7. tag line label check #2 |
| 216 | |
| 217 | cat >tag.sig <<EOF |
| 218 | object $head |
| 219 | type taggggggggggggggggggggggggggggggg |
| 220 | tag |
| 221 | EOF |
| 222 | |
| 223 | check_verify_failure '"tag" line label check #2' \ |
| 224 | '^error:.* badType:' |
| 225 | |
| 226 | ############################################################ |
| 227 | # 8. type line type-name length check |
| 228 | |
| 229 | cat >tag.sig <<EOF |
| 230 | object $head |
| 231 | type taggggggggggggggggggggggggggggggg |
| 232 | tag mytag |
| 233 | EOF |
| 234 | |
| 235 | check_verify_failure '"type" line type-name length check' \ |
| 236 | '^error:.* badType:' |
| 237 | |
| 238 | ############################################################ |
| 239 | # 9. verify object (hash/type) check |
| 240 | |
| 241 | cat >tag.sig <<EOF |
| 242 | object $(test_oid deadbeef) |
| 243 | type tag |
| 244 | tag mytag |
| 245 | tagger . <> 0 +0000 |
| 246 | |
| 247 | EOF |
| 248 | |
| 249 | check_verify_failure 'verify object (hash/type) check -- correct type, nonexisting object' \ |
| 250 | '^fatal: could not read tagged object' \ |
| 251 | --fsck-obj-ok |
| 252 | |
| 253 | cat >tag.sig <<EOF |
| 254 | object $head |
| 255 | type tagggg |
| 256 | tag mytag |
| 257 | tagger . <> 0 +0000 |
| 258 | |
| 259 | EOF |
| 260 | |
| 261 | check_verify_failure 'verify object (hash/type) check -- made-up type, valid object' \ |
| 262 | '^error:.* badType:' |
| 263 | |
| 264 | cat >tag.sig <<EOF |
| 265 | object $(test_oid deadbeef) |
| 266 | type tagggg |
| 267 | tag mytag |
| 268 | tagger . <> 0 +0000 |
| 269 | |
| 270 | EOF |
| 271 | |
| 272 | check_verify_failure 'verify object (hash/type) check -- made-up type, nonexisting object' \ |
| 273 | '^error:.* badType:' |
| 274 | |
| 275 | cat >tag.sig <<EOF |
| 276 | object $head |
| 277 | type tree |
| 278 | tag mytag |
| 279 | tagger . <> 0 +0000 |
| 280 | |
| 281 | EOF |
| 282 | |
| 283 | check_verify_failure 'verify object (hash/type) check -- mismatched type, valid object' \ |
| 284 | '^fatal: object.*tagged as.*tree.*but is.*commit' \ |
| 285 | --fsck-obj-ok |
| 286 | |
| 287 | ############################################################ |
| 288 | # 9.5. verify object (hash/type) check -- replacement |
| 289 | |
| 290 | test_expect_success 'setup replacement of commit -> commit and tree -> blob' ' |
| 291 | git replace $head_parent $head && |
| 292 | git replace -f $tree $blob |
| 293 | ' |
| 294 | |
| 295 | cat >tag.sig <<EOF |
| 296 | object $head_parent |
| 297 | type commit |
| 298 | tag mytag |
| 299 | tagger . <> 0 +0000 |
| 300 | |
| 301 | EOF |
| 302 | |
| 303 | test_expect_mktag_success 'tag to a commit replaced by another commit' |
| 304 | |
| 305 | cat >tag.sig <<EOF |
| 306 | object $tree |
| 307 | type tree |
| 308 | tag mytag |
| 309 | tagger . <> 0 +0000 |
| 310 | |
| 311 | EOF |
| 312 | |
| 313 | check_verify_failure 'verify object (hash/type) check -- mismatched type, valid object' \ |
| 314 | '^fatal: object.*tagged as.*tree.*but is.*blob' \ |
| 315 | --fsck-obj-ok |
| 316 | |
| 317 | ############################################################ |
| 318 | # 10. verify tag-name check |
| 319 | |
| 320 | cat >tag.sig <<EOF |
| 321 | object $head |
| 322 | type commit |
| 323 | tag my tag |
| 324 | tagger . <> 0 +0000 |
| 325 | |
| 326 | EOF |
| 327 | |
| 328 | check_verify_failure 'verify tag-name check' \ |
| 329 | '^error:.* badTagName:' \ |
| 330 | --no-strict \ |
| 331 | --fsck-obj-ok |
| 332 | |
| 333 | ############################################################ |
| 334 | # 11. tagger line label check #1 |
| 335 | |
| 336 | cat >tag.sig <<EOF |
| 337 | object $head |
| 338 | type commit |
| 339 | tag mytag |
| 340 | |
| 341 | This is filler |
| 342 | EOF |
| 343 | |
| 344 | check_verify_failure '"tagger" line label check #1' \ |
| 345 | '^error:.* missingTaggerEntry:' \ |
| 346 | --no-strict \ |
| 347 | --fsck-obj-ok |
| 348 | |
| 349 | ############################################################ |
| 350 | # 12. tagger line label check #2 |
| 351 | |
| 352 | cat >tag.sig <<EOF |
| 353 | object $head |
| 354 | type commit |
| 355 | tag mytag |
| 356 | tagger |
| 357 | |
| 358 | This is filler |
| 359 | EOF |
| 360 | |
| 361 | check_verify_failure '"tagger" line label check #2' \ |
| 362 | '^error:.* missingTaggerEntry:' \ |
| 363 | --no-strict \ |
| 364 | --fsck-obj-ok |
| 365 | |
| 366 | ############################################################ |
| 367 | # 13. allow missing tag author name like fsck |
| 368 | |
| 369 | cat >tag.sig <<EOF |
| 370 | object $head |
| 371 | type commit |
| 372 | tag mytag |
| 373 | tagger <> 0 +0000 |
| 374 | |
| 375 | This is filler |
| 376 | EOF |
| 377 | |
| 378 | test_expect_mktag_success 'allow missing tag author name' |
| 379 | |
| 380 | ############################################################ |
| 381 | # 14. disallow missing tag author name |
| 382 | |
| 383 | cat >tag.sig <<EOF |
| 384 | object $head |
| 385 | type commit |
| 386 | tag mytag |
| 387 | tagger T A Gger < |
| 388 | > 0 +0000 |
| 389 | |
| 390 | EOF |
| 391 | |
| 392 | check_verify_failure 'disallow malformed tagger' \ |
| 393 | '^error:.* badEmail:' \ |
| 394 | --no-strict \ |
| 395 | --fsck-obj-ok |
| 396 | |
| 397 | ############################################################ |
| 398 | # 15. allow empty tag email |
| 399 | |
| 400 | cat >tag.sig <<EOF |
| 401 | object $head |
| 402 | type commit |
| 403 | tag mytag |
| 404 | tagger T A Gger <> 0 +0000 |
| 405 | |
| 406 | EOF |
| 407 | |
| 408 | test_expect_mktag_success 'allow empty tag email' |
| 409 | |
| 410 | ############################################################ |
| 411 | # 16. allow spaces in tag email like fsck |
| 412 | |
| 413 | cat >tag.sig <<EOF |
| 414 | object $head |
| 415 | type commit |
| 416 | tag mytag |
| 417 | tagger T A Gger <tag ger@example.com> 0 +0000 |
| 418 | |
| 419 | EOF |
| 420 | |
| 421 | test_expect_mktag_success 'allow spaces in tag email like fsck' |
| 422 | |
| 423 | ############################################################ |
| 424 | # 17. disallow missing tag timestamp |
| 425 | |
| 426 | tr '_' ' ' >tag.sig <<EOF |
| 427 | object $head |
| 428 | type commit |
| 429 | tag mytag |
| 430 | tagger T A Gger <tagger@example.com>__ |
| 431 | |
| 432 | EOF |
| 433 | |
| 434 | check_verify_failure 'disallow missing tag timestamp' \ |
| 435 | '^error:.* badDate:' |
| 436 | |
| 437 | ############################################################ |
| 438 | # 18. detect invalid tag timestamp1 |
| 439 | |
| 440 | cat >tag.sig <<EOF |
| 441 | object $head |
| 442 | type commit |
| 443 | tag mytag |
| 444 | tagger T A Gger <tagger@example.com> Tue Mar 25 15:47:44 2008 |
| 445 | |
| 446 | EOF |
| 447 | |
| 448 | check_verify_failure 'detect invalid tag timestamp1' \ |
| 449 | '^error:.* badDate:' |
| 450 | |
| 451 | ############################################################ |
| 452 | # 19. detect invalid tag timestamp2 |
| 453 | |
| 454 | cat >tag.sig <<EOF |
| 455 | object $head |
| 456 | type commit |
| 457 | tag mytag |
| 458 | tagger T A Gger <tagger@example.com> 2008-03-31T12:20:15-0500 |
| 459 | |
| 460 | EOF |
| 461 | |
| 462 | check_verify_failure 'detect invalid tag timestamp2' \ |
| 463 | '^error:.* badDate:' |
| 464 | |
| 465 | ############################################################ |
| 466 | # 20. detect invalid tag timezone1 |
| 467 | |
| 468 | cat >tag.sig <<EOF |
| 469 | object $head |
| 470 | type commit |
| 471 | tag mytag |
| 472 | tagger T A Gger <tagger@example.com> 1206478233 GMT |
| 473 | |
| 474 | EOF |
| 475 | |
| 476 | check_verify_failure 'detect invalid tag timezone1' \ |
| 477 | '^error:.* badTimezone:' |
| 478 | |
| 479 | ############################################################ |
| 480 | # 21. detect invalid tag timezone2 |
| 481 | |
| 482 | cat >tag.sig <<EOF |
| 483 | object $head |
| 484 | type commit |
| 485 | tag mytag |
| 486 | tagger T A Gger <tagger@example.com> 1206478233 + 30 |
| 487 | |
| 488 | EOF |
| 489 | |
| 490 | check_verify_failure 'detect invalid tag timezone2' \ |
| 491 | '^error:.* badTimezone:' |
| 492 | |
| 493 | ############################################################ |
| 494 | # 22. allow invalid tag timezone3 (the maximum is -1200/+1400) |
| 495 | |
| 496 | cat >tag.sig <<EOF |
| 497 | object $head |
| 498 | type commit |
| 499 | tag mytag |
| 500 | tagger T A Gger <tagger@example.com> 1206478233 -1430 |
| 501 | |
| 502 | EOF |
| 503 | |
| 504 | test_expect_mktag_success 'allow invalid tag timezone' |
| 505 | |
| 506 | ############################################################ |
| 507 | # 23. detect invalid header entry |
| 508 | |
| 509 | cat >tag.sig <<EOF |
| 510 | object $head |
| 511 | type commit |
| 512 | tag mytag |
| 513 | tagger T A Gger <tagger@example.com> 1206478233 -0500 |
| 514 | this line should not be here |
| 515 | |
| 516 | EOF |
| 517 | |
| 518 | check_verify_failure 'detect invalid header entry' \ |
| 519 | '^error:.* extraHeaderEntry:' \ |
| 520 | --no-strict \ |
| 521 | --fsck-obj-ok |
| 522 | |
| 523 | test_expect_success 'invalid header entry config & fsck' ' |
| 524 | test_must_fail git mktag <tag.sig && |
| 525 | git mktag --no-strict <tag.sig && |
| 526 | |
| 527 | test_must_fail git -c fsck.extraHeaderEntry=error mktag <tag.sig && |
| 528 | test_must_fail git -c fsck.extraHeaderEntry=error mktag --no-strict <tag.sig && |
| 529 | |
| 530 | test_must_fail git -c fsck.extraHeaderEntry=warn mktag <tag.sig && |
| 531 | git -c fsck.extraHeaderEntry=warn mktag --no-strict <tag.sig && |
| 532 | |
| 533 | git -c fsck.extraHeaderEntry=ignore mktag <tag.sig && |
| 534 | git -c fsck.extraHeaderEntry=ignore mktag --no-strict <tag.sig && |
| 535 | |
| 536 | git fsck && |
| 537 | git -c fsck.extraHeaderEntry=warn fsck 2>err && |
| 538 | test_grep "warning .*extraHeaderEntry:" err && |
| 539 | test_must_fail git -c fsck.extraHeaderEntry=error 2>err fsck && |
| 540 | test_grep "error .* extraHeaderEntry:" err |
| 541 | ' |
| 542 | |
| 543 | cat >tag.sig <<EOF |
| 544 | object $head |
| 545 | type commit |
| 546 | tag mytag |
| 547 | tagger T A Gger <tagger@example.com> 1206478233 -0500 |
| 548 | |
| 549 | |
| 550 | this line comes after an extra newline |
| 551 | EOF |
| 552 | |
| 553 | test_expect_mktag_success 'allow extra newlines at start of body' |
| 554 | |
| 555 | cat >tag.sig <<EOF |
| 556 | object $head |
| 557 | type commit |
| 558 | tag mytag |
| 559 | tagger T A Gger <tagger@example.com> 1206478233 -0500 |
| 560 | |
| 561 | EOF |
| 562 | |
| 563 | test_expect_mktag_success 'allow a blank line before an empty body (1)' |
| 564 | |
| 565 | cat >tag.sig <<EOF |
| 566 | object $head |
| 567 | type commit |
| 568 | tag mytag |
| 569 | tagger T A Gger <tagger@example.com> 1206478233 -0500 |
| 570 | EOF |
| 571 | |
| 572 | test_expect_mktag_success 'allow no blank line before an empty body (2)' |
| 573 | |
| 574 | ############################################################ |
| 575 | # 24. create valid tag |
| 576 | |
| 577 | cat >tag.sig <<EOF |
| 578 | object $head |
| 579 | type commit |
| 580 | tag mytag |
| 581 | tagger T A Gger <tagger@example.com> 1206478233 -0500 |
| 582 | EOF |
| 583 | |
| 584 | test_expect_mktag_success 'create valid tag object' |
| 585 | |
| 586 | test_done |