v1.6.11

The first days of siGit Code Review answering replies showed where it still wasted your time: the same finding posted twice, a full review after a rebase that changed nothing, and comments that asked you to go and check something. v1.6.11 is about those.

#It does not repeat itself

A review takes a few minutes, and people answer the previous one in that time. The reviewer used to read the conversation once, before it started, so an answer that arrived while it was working got the same finding again. It now reads the conversation a second time just before posting.

A line that already carries one of its threads takes no second comment, answered or not. An unanswered thread also covers the three lines either side of it, because the same point often comes back anchored a line or two away. If the dropped repeat was more than a nit, the pull request is not approved over it: the first comment is still waiting for you.

#A rebase that changes nothing is not reviewed again

Rebasing or restacking a branch gives it a new head, and every new head used to get a full review. The reviewer now compares the pull request's own patch with the ones it has already reviewed. If nothing in the patch changed, it skips the review and keeps the earlier one, and that earlier review still counts when it decides whether to approve.

A review you ask for by mention always runs.

#Findings name a defect

Too many findings asked the author to "ensure", "verify" or "consider" something the code a few lines away already answered, and some opened by saying the change was correct. The reviewer is now told that a finding states what breaks and which line causes it, and that a question it could answer by reading the file is not a finding. critical is kept for lines the change added.

This is an instruction to a model, not a guarantee. We are measuring how many findings end in a fix, and will say so here if it does not move.

#Ask for a review from the review box

"review this @sigitc" used to work only as a comment in the pull request's conversation. Typed into the review box, or on a line of the diff, it was ignored without a word. All three places count now. A mention in a reply inside an existing thread is still read as part of that conversation, not as a new request, and asking twice in one review starts one review.

#Three more cloud tiers are metered

Onde Cloud added onde-flare, onde-zenith and onde-prism. Requests to them now count against your cloud allowance like every other tier. Until this release they were served without being counted.

---

Release masters: @setoelkahfi and @sigit.